Skip to content

feat: updated mongodb to latest version #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 24, 2025
Merged

feat: updated mongodb to latest version #635

merged 10 commits into from
Sep 24, 2025

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Sep 16, 2025 •
edited
Loading

Description

issue: https://github.ibm.com/GoldenEye/issues/issues/16077

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05 Khuzaima05 self-assigned this Sep 16, 2025
@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 16, 2025

/run pipeline

2 similar comments
@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 16, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 16, 2025

/run pipeline

ocofaigh
ocofaigh requested changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing 7.0 support? Its still supported:
image

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 16, 2025

Before re-running a pipeline, please leave a comment to explain why you are re-running. Did a previous test fail? What was the error?

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 16, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 16, 2025 •
edited
Loading

Pipeline is failing with error unrelated to this pr:

 2025/09/16 11:06:55 Terraform plan | Error: ---
         2025/09/16 11:06:55 Terraform plan | id: terraform-ac1cd648
         2025/09/16 11:06:55 Terraform plan | summary: Gateway Timeout
         2025/09/16 11:06:55 Terraform plan | severity: error
         2025/09/16 11:06:55 Terraform plan | resource: ibm_database
         2025/09/16 11:06:55 Terraform plan | operation: CustomizeDiff
         2025/09/16 11:06:55 Terraform plan | component:
         2025/09/16 11:06:55 Terraform plan |   name: github.com/IBM-Cloud/terraform-provider-ibm
         2025/09/16 11:06:55 Terraform plan |   version: 1.82.1
         2025/09/16 11:06:55 Terraform plan | ---
         2025/09/16 11:06:55 Terraform plan | 
         2025/09/16 11:06:55 Terraform plan | 
         2025/09/16 11:06:55 Terraform plan |   with module.mongodb.module.mongodb[0].ibm_database.mongodb,
         2025/09/16 11:06:55 Terraform plan |   on ../../main.tf line 160, in resource "ibm_database" "mongodb":
         2025/09/16 11:06:55 Terraform plan |  160: resource "ibm_database" "mongodb" {
         2025/09/16 11:06:55 Terraform plan | 
         2025/09/16 11:06:56 Terraform PLAN error: Terraform PLAN errorexit status 1

Thread : https://ibm-cloudplatform.slack.com/archives/C534XRCF3/p1757930719682429

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 22, 2025

/run pipeline

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 23, 2025

/run pipeline

shemau
shemau reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that common-dev-assets needed changing Tracking the version and merge conflicts often becomes an issue. I think a merge from main where the known issue with detect-secrets in the pipeline was fixed at the weekend should have resolved this.

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 23, 2025

/run pipeline

shemau
shemau requested changes Sep 23, 2025
View reviewed changes
@shemau
Copy link
Contributor

shemau commented Sep 23, 2025

Conalls first comment appears to have been overlooked. There is a test gap after this change, in that no tests run 7.0. Between defaulting to 8.0 and null mapping to preferred (also 8.0) all tests are 8.0.

We should keep at least one at the lowest version. Maybe have the existing resource test create a 7.0, or there appear to be 4 DA tests, make one of them use 7.0.

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 23, 2025

/run pipeline

shemau
shemau approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 24, 2025

Why are you removing 7.0 support? Its still supported: image

Updated

@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Sep 24, 2025 •
edited
Loading

Before re-running a pipeline, please leave a comment to explain why you are re-running. Did a previous test fail? What was the error?

Pipeline was failing with error unrelated to this pr:

 2025/09/16 11:06:55 Terraform plan | Error: ---
         2025/09/16 11:06:55 Terraform plan | id: terraform-ac1cd648
         2025/09/16 11:06:55 Terraform plan | summary: Gateway Timeout
         2025/09/16 11:06:55 Terraform plan | severity: error
         2025/09/16 11:06:55 Terraform plan | resource: ibm_database
         2025/09/16 11:06:55 Terraform plan | operation: CustomizeDiff
         2025/09/16 11:06:55 Terraform plan | component:
         2025/09/16 11:06:55 Terraform plan |   name: github.com/IBM-Cloud/terraform-provider-ibm
         2025/09/16 11:06:55 Terraform plan |   version: 1.82.1
         2025/09/16 11:06:55 Terraform plan | ---
         2025/09/16 11:06:55 Terraform plan | 
         2025/09/16 11:06:55 Terraform plan | 
         2025/09/16 11:06:55 Terraform plan |   with module.mongodb.module.mongodb[0].ibm_database.mongodb,
         2025/09/16 11:06:55 Terraform plan |   on ../../main.tf line 160, in resource "ibm_database" "mongodb":
         2025/09/16 11:06:55 Terraform plan |  160: resource "ibm_database" "mongodb" {
         2025/09/16 11:06:55 Terraform plan | 
         2025/09/16 11:06:56 Terraform PLAN error: Terraform PLAN errorexit status 1

Thread : https://ibm-cloudplatform.slack.com/archives/C534XRCF3/p1757930719682429

@Khuzaima05 Khuzaima05 requested a review from ocofaigh September 24, 2025 04:29
@ocofaigh ocofaigh merged commit 8e82484 into main Sep 24, 2025
2 checks passed
@ocofaigh ocofaigh deleted the issue-16077 branch September 24, 2025 08:16
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Sep 24, 2025

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shemau shemau shemau approved these changes

@ocofaigh ocofaigh ocofaigh approved these changes

@rajatagarwal-ibm rajatagarwal-ibm Awaiting requested review from rajatagarwal-ibm rajatagarwal-ibm is a code owner

Assignees

@Khuzaima05 Khuzaima05

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Khuzaima05 @ocofaigh @shemau @terraform-ibm-modules-ops @HarikaPonna